kezhenxu94 commented on a change in pull request #2730: Provide plugin for Solr-7.x(client) URL: https://github.com/apache/skywalking/pull/2730#discussion_r287595032
########## File path: apm-sniffer/apm-sdk-plugin/solrj-7.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/solrj/commons/Context.java ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.plugin.solrj.commons; + +import org.apache.http.Header; +import org.apache.http.HttpEntity; + +public class Context { + private static final ThreadLocal<Context> CONTEXT = new ThreadLocal<Context>() { Review comment: I noticed that the `Context` you defined is used only for setting the tags? In the documentation, [Advanced API's](https://github.com/apache/skywalking/blob/master/docs/en/guides/Java-Plugin-Development-Guide.md#advanced-apis), there is a paragraph saying: > There is a set of advanced APIs in Span, which work specific for async scenario. When tags, logs, attributes(**including end time**) of the span needs to set in another thread, you should use these APIs. seems these API's are more suitable here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
