wu-sheng commented on pull request #51: URL: https://github.com/apache/skywalking-nodejs/pull/51#issuecomment-841603595
> currently I have it set as component Component.HTTP_SERVER rather than its own Azure component name, should that change? I think once this is for AZure only, we should have a new component for it. > And should it have its own Azure logo? Which may be shared in the future with other Azure Function instrumented trigger functions like RabbitMQ? Or should they differentiate? I think we should have an Azure logo, to indicate this is user's FaaS logic service/function. RabbitMQ could be shared, even that is Azure hosted MQ service. > Also this requires manual instrumentation (although very easy), how do you guys feel about that? If there is no chance to be auto-instrumentation, it is fine as manual. We have manual agent/SDK plugins in other language agents too. > I've added a new version code for a plugin of "!" to indicate that the plugin does not check version on install since it is applied manually. @kezhenxu94 WDYT? > There is also the question of a CI test which may be a bit complicated to do and I can't really look into that at at the moment since I have a few other things which require my attention. Would need a docker image with Azure CLI tools to run local. CI is recommended, if possible. We could delay it a little if your time is limited for now. But once someone uses this and faces bug, you have to recheck locally. User can't tell the difference between your use case and their own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
