wu-sheng commented on a change in pull request #6888:
URL: https://github.com/apache/skywalking/pull/6888#discussion_r633104509
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/event/Source.java
##########
@@ -29,4 +30,18 @@
private String service;
private String serviceInstance;
private String endpoint;
+
+ public String getSourcesStr() {
Review comment:
I am super confused about this logic, every entity has a very clear ID
rule, managed by `IDManager` in SkyWalking. Why do you create so many of this
kind of method in here and `AlarmMessage`?
The codes seem to be changed randomly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
