xuanyu66 opened a new issue #6955:
URL: https://github.com/apache/skywalking/issues/6955
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Bug
- What happened?
I changed slowTraceSegmentThreshold but it doesn't work
I reviewed code, TraceSampleRateWatcher was not registered
```
org.apache.skywalking.oap.server.analyzer.provider.AnalyzerModuleProvider
@Override
public void prepare() throws ServiceNotProvidedException,
ModuleStartException {
thresholds = new
DBLatencyThresholdsAndWatcher(moduleConfig.getSlowDBAccessThreshold(), this);
uninstrumentedGatewaysConfig = new
UninstrumentedGatewaysConfig(this);
traceSampleRateWatcher = new TraceSampleRateWatcher(this);
traceLatencyThresholdsAndWatcher = new
TraceLatencyThresholdsAndWatcher(this);
moduleConfig.setDbLatencyThresholdsAndWatcher(thresholds);
moduleConfig.setUninstrumentedGatewaysConfig(uninstrumentedGatewaysConfig);
moduleConfig.setTraceSampleRateWatcher(traceSampleRateWatcher);
moduleConfig.setTraceLatencyThresholdsAndWatcher(traceLatencyThresholdsAndWatcher);
segmentParserService = new SegmentParserServiceImpl(getManager(),
moduleConfig);
this.registerServiceImplementation(ISegmentParserService.class,
segmentParserService);
meterConfigs = MeterConfigs.loadConfig(
moduleConfig.getConfigPath(),
moduleConfig.meterAnalyzerActiveFileNames());
processService = new MeterProcessService(getManager());
this.registerServiceImplementation(IMeterProcessService.class,
processService);
}
@Override
public void start() throws ModuleStartException {
// load official analysis
getManager().find(CoreModule.NAME)
.provider()
.getService(OALEngineLoaderService.class)
.load(CoreOALDefine.INSTANCE);
DynamicConfigurationService dynamicConfigurationService =
getManager().find(ConfigurationModule.NAME)
.provider()
.getService(
DynamicConfigurationService.class);
dynamicConfigurationService.registerConfigChangeWatcher(thresholds);
dynamicConfigurationService.registerConfigChangeWatcher(uninstrumentedGatewaysConfig);
dynamicConfigurationService.registerConfigChangeWatcher(traceSampleRateWatcher);
segmentParserService.setListenerManager(listenerManager());
processService.start(meterConfigs);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
