gxthrj commented on issue #6971:
URL: https://github.com/apache/skywalking/issues/6971#issuecomment-843679109


   > It's a bit tricky here, but defaulting to "Gauge" in the "HELP" line is 
intentional.
   > 
   > Referring to Prometheus metric specification, if there's no "TYPE" line, 
the metric will be parsed as "untyped". But MAL CAN'T handle such metrics, will 
complain about missing type.
   > 
   > Based on that, I default it to "Gauge".
   
   Got it , but the second question is 
[here](https://github.com/apache/skywalking/blob/master/oap-server/server-library/library-util/src/main/java/org/apache/skywalking/oap/server/library/util/prometheus/parser/TextParser.java#L109),
 I think should set `ctx.type` instead of `ctx.name`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to