wu-sheng commented on a change in pull request #2770: fix apm-agent-core maven
pom file shade-plugin define bug (#2769)
URL: https://github.com/apache/skywalking/pull/2770#discussion_r287933670
##########
File path: apm-sniffer/apm-agent-core/pom.xml
##########
@@ -53,10 +53,8 @@
<shade.io.netty.target>${shade.package}.${shade.io.netty.source}</shade.io.netty.target>
<shade.io.opencensus.source>io.opencensus</shade.io.opencensus.source>
<shade.io.opencensus.target>${shade.package}.${shade.io.opencensus.source}</shade.io.opencensus.target>
-
<shade.org.apache.http.source>org.apache.http</shade.org.apache.http.source>
-
<shade.org.apache.http.target>${shade.package}.${shade.org.apache.http.source}</shade.org.apache.http.target>
<shade.org.apache.commons.source>org.apache.commons</shade.org.apache.commons.source>
-
<shade.org.apache.commons.target>${shade.package}.${shade.org.apache.http.source}
+
<shade.org.apache.commons.target>${shade.package}.${shade.org.apache.commons.source}
Review comment:
Based on the current agent.jar, we even don't depend on Apache commons too.
Please remove these two and shade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
