constanine commented on pull request #488:
URL: 
https://github.com/apache/skywalking-rocketbot-ui/pull/488#issuecomment-843756912


   > I only write several comments here. You can't find lint errors as you use 
`js` to code, rather than `ts`. **Please use `ts`.**
   > `<script lang="ts">.....</script>`
   > 
   > When I input page number, here always find this error.
   > 
![1](https://user-images.githubusercontent.com/20871783/118656765-69970780-b81d-11eb-935a-36e89d2a8c30.png)
   > 
   > demo env works well
   > 
![2](https://user-images.githubusercontent.com/20871783/118657023-a6fb9500-b81d-11eb-8859-7497559b4b18.png)
   
   Are you sure to be `<script lang="ts">.....</script>`? I see in the master 
branch,trace-detail-chart-tree.vue、trace-detail-chart-list.vue and 
trace-detail-chart-table.vue all use `<script lang="js">.....</script>`,I don't 
want to break some rule, as other do... 
   Or you‘re ready to change these vue file to use `<script 
lang="ts">.....</script>`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to