hanahmily commented on issue #2771: Filtering pods not in 'Running' phase URL: https://github.com/apache/skywalking/pull/2771#issuecomment-496394626 Never mind. Kubernetes API always set it to a non-null value. Hongtao Gao Apache SkyWalking && Apache ShardingSphere Twitter, @hanahmily > On May 28, 2019, at 3:10 PM, 吴晟 Wu Sheng <[email protected]> wrote: > > @wu-sheng approved this pull request. > > LGTM, if NPE wouldn't happen. > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub <https://github.com/apache/skywalking/pull/2771?email_source=notifications&email_token=AAO6UWLHUEKRZEEC4O7NCMLPXTLHLA5CNFSM4HQAIX32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZZ7UJI#pullrequestreview-242481701>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO6UWLB6ISMETNHC3XKDHLPXTLHLANCNFSM4HQAIX3Q>. >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
