ascrutae commented on issue #2774: Jetty client intercept HttpRequest send with two args may be more userful URL: https://github.com/apache/skywalking/pull/2774#issuecomment-496751243 You should also need to trace the listener if you want to support asynchronous call. 归田 <[email protected]>于2019年5月29日 周三上午9:36写道： > The jetty plugin only supports to trace the send method, because this > method is a synchronization call, but the send method with two parameters > is the asynchronous call. If you want to supports to trace the asynchronous > call, You should add new instrumentation to support it. > > Why cant support asynchronous call，the SyncHttpRequestSendInterceptor > afterMethod just call ContextManager.stopSpan() and not do other thing. I > think it has nothing to do with the synchronization or asynchronous call. > The jetty plugin supports to trace the called service and not care about > the response. > > — > You are receiving this because your review was requested. > > > Reply to this email directly, view it on GitHub > <https://github.com/apache/skywalking/pull/2774?email_source=notifications&email_token=AC64HXZEN52UXMYAQDPZINTPXXM2NA5CNFSM4HQBCK7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWN453I#issuecomment-496750317>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AC64HX7KE2WPSKJBOBLAYXDPXXM2NANCNFSM4HQBCK7A> > . > -- Regards, Xin
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
