lujiajing1126 commented on a change in pull request #6973: URL: https://github.com/apache/skywalking/pull/6973#discussion_r635932191
########## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/util/CrossThreadRefContainer.java ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.agent.core.context.util; + +public class CrossThreadRefContainer { Review comment: > We have v2 APIs added specifically for this case. @dmsolr is a member of SkyWalking PMC. He is the lead of these new APIs, and we have changed one plugin which has a better performance. You could sync with the master branch, then you could use v2 to make codes easier and better. Thanks for the information. I will try to adapt the Spring plugins with the new API. But I don't know whether I should/have to transform all spring plugins in this PR? Besides, an additional e2e case have to be added for this particular issue. I will work on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
