wayilau commented on issue #2725: Add cluster-etcd-plugin
URL: https://github.com/apache/skywalking/pull/2725#issuecomment-496823244
 
 
   > @JaredTan95 Please review and test again. Also, please verify the dist 
tar, how many jars are added.
   > 
   > @wayilau New dependencies need to be added here, 
https://github.com/apache/skywalking/blob/master/apm-dist/release-docs/LICENSE#L204
 by following current catalog. If there is Apache LICENSE 2.0, I assume yes, 
you need to check NOTICE of original repo, if NOTICE is there, you need to add 
the copy of the content to 
https://github.com/apache/skywalking/tree/master/apm-dist/release-docs
   > Please list the libs, license, notice status here right, before you update 
the PR.
   
   ok, I  am going to start doing this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to