wu-sheng commented on issue #2730: Provide plugin for Solr-7.x(client) URL: https://github.com/apache/skywalking/pull/2730#issuecomment-497754218 @dmsolr I just read your reply again, here is my reply > status : status of response. Why this status doesn't match span status? Which values of these status? > qtime : solr Why doesn't this match the span duration? If this represents target(solr server) duration, we should have solr server trace in next step, right? Then we still don't need this. > docsSize commitWithin softCommit delete.by softCommit maxOptimizeSegs waitFLush waitSearch All these are either execution results or parameters. In my mind, all these should only be tagged when the user explicitly opens it. Add config item to `Config#Plugin#SolrJ`. Because all these String tags cost a lot of network and storage. For `URLEncoder`, it is a very simple encode OP, you could easily decode it. Just google it :) I think that perfectly match the statement. And in your example, could you tell me, what does `mycore` mean? Look like your operation name include it. ___ Out of the above context, my other question is, what is purpose and benefit to provide Solr server plugin. Thinking in these ways 1. We have no intention to improve solr server performance. 1. We analysis database performance based on client(Exist Span), read `MultiScopesSpanListener#L162). It will be confusing, both service metrics and database metrics dashboards showing with different names. Service dashboard shows agent config service_code, database dashboards show based on client(solrJ) peer. The point is, I hope we could focus on APM, and don't get user confused.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
