kezhenxu94 commented on a change in pull request #42:
URL:
https://github.com/apache/skywalking-satellite/pull/42#discussion_r645440469
##########
File path: dist/LICENSE
##########
@@ -216,6 +216,8 @@ The following components are provided under the Apache
License. See project link
The text of each license is the standard Apache 2.0 license.
client_golang (prometheus) v1.9.0:
https://github.com/prometheus/client_golang Apache 2.0
grpc-go (grpc) v1.36.1: https://github.com/grpc/grpc-go Apache 2.0
+ prometheus (prometheus) v1.8.2: http://github.com/prometheus/prometheus
Apache 2.0
+ go-yaml (yaml) v2: https://github.com/go-yaml/yaml Apache 2.0
Review comment:
Since https://github.com/apache/skywalking-satellite/pull/49 is also
going to use yaml and it uses v3, let's use v3 for this as well, newer version
should be more preferable, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
