This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch polish_debug_logging in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 8a478295a1b7a11d346c31df962a6746eca858a1 Author: JaredTan95 <[email protected]> AuthorDate: Sat Jun 5 09:26:09 2021 +0800 polish debug logging avoid null value. --- .../trace/parser/listener/SegmentAnalysisListener.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/SegmentAnalysisListener.java b/oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/SegmentAnalysisListener.java index 6fc5a76..4c8c96d 100644 --- a/oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/SegmentAnalysisListener.java +++ b/oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/SegmentAnalysisListener.java @@ -170,14 +170,17 @@ public class SegmentAnalysisListener implements FirstAnalysisListener, EntryAnal @Override public void build() { - if (log.isDebugEnabled()) { - log.debug("segment listener build, segment id: {}", segment.getSegmentId()); - } - if (sampleStatus.equals(SAMPLE_STATUS.IGNORE)) { + if (log.isDebugEnabled()) { + log.debug("segment ignored, trace id: {}", segment.getTraceId()); + } return; } + if (log.isDebugEnabled()) { + log.debug("segment listener build, segment id: {}", segment.getSegmentId()); + } + segment.setEndpointId(endpointId); segment.setEndpointName(endpointName);
