JaredTan95 commented on a change in pull request #7070:
URL: https://github.com/apache/skywalking/pull/7070#discussion_r645924822
##########
File path:
oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/SegmentAnalysisListener.java
##########
@@ -170,14 +170,17 @@ private void appendSearchableTags(SpanObject span) {
@Override
public void build() {
- if (log.isDebugEnabled()) {
- log.debug("segment listener build, segment id: {}",
segment.getSegmentId());
- }
-
if (sampleStatus.equals(SAMPLE_STATUS.IGNORE)) {
+ if (log.isDebugEnabled()) {
+ log.debug("segment ignored, trace id: {}",
segment.getTraceId());
Review comment:
In addition to lowering the sample rate, everything else configuration
can be configured with the default value in master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
