wu-sheng commented on a change in pull request #7069:
URL: https://github.com/apache/skywalking/pull/7069#discussion_r646081108
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/boot/ServiceManager.java
##########
@@ -36,11 +38,13 @@
INSTANCE;
private static final ILog LOGGER =
LogManager.getLogger(ServiceManager.class);
+ public static Instrumentation INSTRUMENTATION;
Review comment:
This is not recommended way to expose. Metadata like this should be
loaded by core directly. Not a service should do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
