ascrutae opened a new pull request #2820: Fix the span cannot stop when forward request URL: https://github.com/apache/skywalking/pull/2820 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues #2637 ___ ### Bug fix - Bug description. This bug caused by the forward flag not clearing in time and it reasoned that the span that spring plugin generated could not finish, and here are the steps of issue #2637 1. Create entry span of tomcat (Tomcat plugin) 2. Create entry span of spring controller (Spring plugin) 3. Invoke forward method and set forward flag and forward event (Tomcat plugin) 4. Create entry span but DO NOTHING, because the forward flag has set[1] (Spring plugin) 5. Finish entry span but Do NOTHING, because the forward flag has set[1] (Spring plugin) 6. Finish forward method (Tomcat plugin) 7. Finish entry span, but Do NOTHING, because the forward flag has set[1] (Spring plugin) 8. Finish entry span (Tomcat plugin) - How to fix? Remove the `SW_FORWARD_REQUEST_FLAG` flag when finished `forward` method. [1]: https://github.com/apache/skywalking/pull/1325
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
