tom-pytel opened a new pull request #125:
URL: https://github.com/apache/skywalking-python/pull/125


   There are several things here all mixed together because they are required 
to make celery work. The main problem is that the default celery configuration 
is to run the backend server via multiprocessing `fork()` for true concurrency, 
which this agent was not set up to handle. I added  this but unfortunately I 
could not get grpc working with `fork()` (does not mean it can't, just I 
couldn't do it in my restricted timeline), so I fixed a minor bug in the http 
protocol which now works correctly with `fork()`. A few more tweaks needed 
before this can be merged.
   
   * NOTE: The changes in `context.py` are not finished. Entry and exit spans 
can not indiscriminately reuse each other since they may not be related at all. 
An explicit inheritance mechanism is needed to indicate which plugins can 
inherit a span from which others. I will eventually implement this in the same 
way I did for the Node agent, but for now this works. I will probably 
eventually implement most of the Node features and cleanups here.
   
   - [ ] Add a test case for the new plugin
   - [ ] Add a component id in [the main 
repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
   - [ ] Add a logo in [the UI 
repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
   - [ ] Rebuild the `requirements.txt` by running 
`tools/env/build_requirements_(linux|windows).sh`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to