kezhenxu94 commented on a change in pull request #125:
URL: https://github.com/apache/skywalking-python/pull/125#discussion_r656722698
##########
File path: skywalking/agent/__init__.py
##########
@@ -65,14 +76,40 @@ def __init():
__protocol = KafkaProtocol()
plugins.install()
+ __init_threading()
def __fini():
__protocol.report(__queue, False)
__queue.join()
+ __finished.set()
+
+
+def __fork_before():
+ if config.protocol != 'http':
+ logger.warning('fork() not currently supported with %s protocol' %
config.protocol)
Review comment:
I didn't mean to close parent channel and create in child process by
reusing the agent in parent. What I meant is to start another independent agent
in child process and leave the parent one there because there may be other
things that may need to be traced in parent process. Can you take a look at
https://github.com/apache/skywalking-python/blob/c73398544694ff7c64b083a5ee0d6d82578971cf/skywalking/trace/ipc/process.py#L30-L34
... and see whether that helps, it is generally what I propose to do in
forked processes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
