wu-sheng commented on a change in pull request #7153:
URL: https://github.com/apache/skywalking/pull/7153#discussion_r657171941
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java
##########
@@ -77,9 +83,16 @@ public void start(ModuleManager moduleManager,
CoreModuleConfig moduleConfig) {
"persistence_timer_bulk_execute_latency", "Latency of the execute
stage in persistence timer",
MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE
);
+ allLatency = metricsCreator.createHistogramMetric(
+ "persistence_timer_bulk_all_latency", "Latency of the all stage in
persistence timer",
+ MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE
+ );
+
syncOperationThreadsNum = moduleConfig.getSyncThreads();
maxSyncoperationNum = moduleConfig.getMaxSyncOperationNum();
+ batchExecutorService = Executors.newSingleThreadExecutor();
Review comment:
We will use one more thread because of this, besides the new add
`moduleConfig#getPrepareThreads()`. Do we have a way to avoid this? Every
thread is a very expensive resource in the OAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
