CoffeeLatte007 commented on issue #2714: [WIP]Seata Agent URL: https://github.com/apache/skywalking/pull/2714#issuecomment-500085774 > > Some point were left out: > > -handleRetryRollbacking > > -handleRetryCommitting > > -handleAsyncCommitting > > -LockManager > > Hi @CoffeeLatte007 , thanks for reviewing, the `LockManager` instrumentation is added(as the trace below. > > As for the three `handleXxx` methods, they are indeed not instrumented, but the underlying operations (`BranchCommit`, `BranchRollback`) are instrumented, therefore the interactions between TC and TM/RM are in trace links. > > I think it's enough to show the interactions between TC and TM/RM, instrumenting the three methods just adds some local spans, without more detailed information? > > Please correct me if I'm wrong. Thanks :-) > >  The underlying operations are used in many methods. We don't know which method is using it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
