wu-sheng commented on a change in pull request #7153:
URL: https://github.com/apache/skywalking/pull/7153#discussion_r657927073
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java
##########
@@ -43,16 +48,18 @@
@Slf4j
public enum PersistenceTimer {
INSTANCE;
- private Boolean isStarted = false;
+ @VisibleForTesting
+ Boolean isStarted = false;
Review comment:
You have `@VisibleForTesting`, why remove private? And why use
`Boolean`, rather than `boolean`. I can't see anyone uses it as NULL. I know
this is a legacy fault, but please fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
