wu-sheng commented on a change in pull request #7153:
URL: https://github.com/apache/skywalking/pull/7153#discussion_r657957705
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java
##########
@@ -43,16 +48,18 @@
@Slf4j
public enum PersistenceTimer {
INSTANCE;
- private Boolean isStarted = false;
+ @VisibleForTesting
Review comment:
> 2021-06-24T13:37:45.9314106Z [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile
(default-testCompile) on project server-core: Compilation failure
2021-06-24T13:37:45.9317124Z [ERROR]
/home/runner/work/skywalking/skywalking/oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimerTest.java:[80,34]
isStarted has private access in
Is this annotation really working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
