kezhenxu94 commented on a change in pull request #2840: Support exporter runs
in increment and total modes
URL: https://github.com/apache/skywalking/pull/2840#discussion_r291810256
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/exporter/MetricValuesExportService.java
##########
@@ -27,5 +26,10 @@
* @author wusheng
*/
public interface MetricValuesExportService extends Service {
- void export(MetricsMetaInfo meta, Metrics metrics);
+ /**
+ * This method is sync-mode export, the performance effects the
persistence result. Queue mode is high recommended.
Review comment:
high recommended => highly recommended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
