wu-sheng commented on a change in pull request #7217:
URL: https://github.com/apache/skywalking/pull/7217#discussion_r661951304
##########
File path:
apm-sniffer/apm-sdk-plugin/mssql-commons/src/main/java/org/apache/skywalking/apm/plugin/mssql/commons/PreparedStatementExecuteMethodsInterceptor.java
##########
@@ -47,6 +49,13 @@ public final void beforeMethod(EnhancedInstance objInst,
Method method, Object[]
Tags.DB_INSTANCE.set(span, connectInfo.getDatabaseName());
Tags.DB_STATEMENT.set(span,
SqlBodyUtil.limitSqlBodySize(cacheObject.getSql()));
span.setComponent(connectInfo.getComponent());
+ if (JDBCPluginConfig.Plugin.JDBC.TRACE_SQL_PARAMETERS) {
Review comment:
TRACE_SQL_PARAMETERS is false in default, you need to activate it in the
test scenario. I can't see the change, could you recheck?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
