kezhenxu94 commented on a change in pull request #7220:
URL: https://github.com/apache/skywalking/pull/7220#discussion_r661951208
##########
File path: CHANGES.md
##########
@@ -63,6 +63,7 @@ Release Notes.
metrics. The timeout of the cache for minute and hour level metrics has been
prolonged to ~5 min.
* Performance: Add L1 aggregation flush period, which reduce the CPU load and
help young GC.
* Support connectTimeout and socketTimeout settings for ElasticSearch6 and
ElasticSearch7 storages.
+* replace zuul proxy with spring cloud gateway 2.x. in webapp module
Review comment:
```suggestion
* Replace zuul proxy with spring cloud gateway 2.x. in webapp module.
```
##########
File path: apm-webapp/src/main/resources/application.yml
##########
@@ -17,28 +17,28 @@
server:
port: 8080
-zuul:
- ignoredServices: '*'
- routes:
- api:
- path: /graphql
- serviceId: collector
- login:
- path: /login/account
- serviceId: collector
-
-collector:
- path: /graphql
- ribbon:
- # Point to all backend's restHost:restPort, split by ,
- listOfServers: 127.0.0.1:12800
-
spring:
- resources:
- add-mappings: false
+ cloud:
+ gateway:
+ routes:
+ - id: oap-route
+ uri: lb://oap-service
+ predicates:
+ - Path=/graphql/**
+ discovery:
+ client:
+ simple:
+ instances:
+ oap-service:
+ - uri: http://127.0.0.1:12800
Review comment:
Need some comments here, for example
```
# Array of all backend's restHost:restPort
oap-service:
- uri: http://127.0.0.1:12800
# - uri: http://<oap-host-1>:<oap-port1>
# - uri: http://<oap-host-2>:<oap-port2>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
