hanahmily commented on a change in pull request #12:
URL: https://github.com/apache/skywalking-banyandb/pull/12#discussion_r662020167
##########
File path: pkg/logger/setting.go
##########
@@ -66,24 +68,16 @@ func Init(cfg Logging) (err error) {
// getLogger initializes a root logger
func getLogger(cfg Logging) (*Logger, error) {
- // parse logging level
- level := zap.NewAtomicLevelAt(zapcore.InfoLevel)
- if err := level.UnmarshalText([]byte(cfg.Level)); err != nil {
+ lvl, err := zerolog.ParseLevel(cfg.Level)
+ if err != nil {
return nil, err
}
- var encoderConfig zap.Config
+ w := io.Writer(os.Stderr)
switch cfg.Env {
case "dev":
- encoderConfig = zap.NewDevelopmentConfig()
- encoderConfig.EncoderConfig.EncodeLevel =
zapcore.CapitalColorLevelEncoder
- break
+ w = zerolog.ConsoleWriter{Out: os.Stderr}
Review comment:
Would you use https://github.com/rs/zerolog#pretty-logging to format dev
log like:
`// Output: 2006-01-02T15:04:05Z07:00 | INFO | ***Hello World**** foo:BAR`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
