dmsolr commented on a change in pull request #7215:
URL: https://github.com/apache/skywalking/pull/7215#discussion_r663520113
##########
File path: oap-server/server-library/library-server/pom.xml
##########
@@ -59,5 +59,21 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-servlet</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-handler</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec-http</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec-http2</artifactId>
+ </dependency>
Review comment:
@kezhenxu94 reminded me what there is a CVE issue in netty 4.1.45.
Therefore we upgraded the netty's bom to 4.1.65 and remove this version.
I excluded netty from grpc-netty, because grpc-netty included netty 4.1.45.
So that we have to explicitly add those dependencies. (the same as above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
