Switch-vov commented on pull request #7243: URL: https://github.com/apache/skywalking/pull/7243#issuecomment-874510962
> > > Follow the GitHub Action control file, it should not hard to understand, if you have known maven, unit test, and docker/docker-compose > > > > > > I think this isn't hard, but i need some time learning it. > > I will write some e2e test case in the week. > > Oh, you don't need to write a new one. There are many existing cases which is verifying JVM-related metrics. You just need to add one metric about thread, the other about class loaded to verify the codes. > Because code reviewers can't find runtime issues. I add some metrics in [MetricsQuery.java](https://github.com/apache/skywalking/pull/7243/files#diff-a0a708009817f87fec4c8cc48708ecb6185015cabf9d356e645e96e5fffa7370). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
