sonatype-lift[bot] commented on a change in pull request #125:
URL: https://github.com/apache/skywalking-python/pull/125#discussion_r663975843
##########
File path: skywalking/config.py
##########
@@ -59,13 +59,14 @@
kafka_bootstrap_servers = os.getenv('SW_KAFKA_REPORTER_BOOTSTRAP_SERVERS') or
"localhost:9092" # type: str
kafka_topic_management = os.getenv('SW_KAFKA_REPORTER_TOPIC_MANAGEMENT') or
"skywalking-managements" # type: str
kafka_topic_segment = os.getenv('SW_KAFKA_REPORTER_TOPIC_SEGMENT') or
"skywalking-segments" # type: str
+celery_parameters_length = int(os.getenv('SW_CELERY_PARAMETERS_LENGTH') or
'512')
def init(
service: str = None,
instance: str = None,
collector: str = None,
- protocol_type: str = 'grpc',
+ protocol_type: str = None,
Review comment:
*Incompatible variable type:* protocol_type is declared to have type
`str` but is used as type `None`.
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
##########
File path: skywalking/config.py
##########
@@ -59,13 +59,14 @@
kafka_bootstrap_servers = os.getenv('SW_KAFKA_REPORTER_BOOTSTRAP_SERVERS') or
"localhost:9092" # type: str
kafka_topic_management = os.getenv('SW_KAFKA_REPORTER_TOPIC_MANAGEMENT') or
"skywalking-managements" # type: str
kafka_topic_segment = os.getenv('SW_KAFKA_REPORTER_TOPIC_SEGMENT') or
"skywalking-segments" # type: str
+celery_parameters_length = int(os.getenv('SW_CELERY_PARAMETERS_LENGTH') or
'512')
def init(
service: str = None,
instance: str = None,
collector: str = None,
- protocol_type: str = 'grpc',
+ protocol_type: str = None,
Review comment:
I've recorded this as ignored for this pull request. If you change your
mind, just comment `@sonatype-lift unignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
