wu-sheng commented on pull request #7263:
URL: https://github.com/apache/skywalking/pull/7263#issuecomment-877055148


   > > > > Is this static compilation available for runtime script update or 
new script as input?
   > > > 
   > > > 
   > > > > I am thinking to share the same core for #7168 requirement
   > > > 
   > > > 
   > > > Yes. Whenever a new LAL DSL script is created, we can compile it to 
Java-style static byte codes once, after that its execution performance is 
close to Java.
   > > 
   > > 
   > > Then my next question would be, if we use this as debug tool? Whether 
could cause metaspace oom? Or we need to set up previous dymanic engine for 
debug tool.
   > 
   > In terms of dynamic update LAL / MAL and debugging tool for LAL, we can 
discuss in their corresponding issues because metaspace OOM may also exist 
before this PR, it's due to Groovy Shell's compilation and references to some 
class loaders, etc., when we want to dynamically update LAL / MAL and debug 
them in UI, we should consider this then.
   
   FYI @dmsolr This change should have a very clear impact for your update 
feature. Please recheck at your sides, especially whether update cause memory 
leak(because of new classes generated).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to