tom-pytel commented on a change in pull request #125:
URL: https://github.com/apache/skywalking-python/pull/125#discussion_r667495773
##########
File path: setup.py
##########
@@ -33,12 +33,13 @@
author="Apache",
author_email="[email protected]",
license="Apache 2.0",
- packages=find_packages(exclude=("tests",)),
+ packages=find_packages(exclude=("tests", "tests.*")),
include_package_data=True,
install_requires=[
"grpcio",
"grpcio-tools",
"packaging",
+ "requests",
Review comment:
Sure if it is problematic then we remove it from the required
dependencies if the license will cause problems. I could also look into using a
different communication method like `urllib.request` or `urllib3.request`?
As for http protocol, we are doing stress testing here and finding that grpc
is not entirely reliable and the http protocol is actually a lot more stable.
Not sure why this is happening, maybe grpc is not configured correctly or the
timeouts are causing problems. But the main result is that you should consider
the http protocol a little more than just optional at this point since it is
capable of working in scenarios for us where grpc breaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
