lujiajing1126 commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-banyandb/pull/14#discussion_r667640617
##########
File path: pkg/logical/expr_literal.go
##########
@@ -52,12 +57,20 @@ func (i *int64Literal) String() string {
return strconv.FormatInt(i.int64, 10)
}
-var _ Expr = (*int64ArrLiteral)(nil)
+var _ LiteralExpr = (*int64ArrLiteral)(nil)
type int64ArrLiteral struct {
arr []int64
}
+func (i *int64ArrLiteral) Bytes() [][]byte {
+ var b [][]byte
Review comment:
I've created a slice with capacity, for both `int64ArrLiteral` and
`strArrLiteral`.
Later, we may add a general byte buffer module to optimize memory allocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
