wu-sheng edited a comment on pull request #7340:
URL: https://github.com/apache/skywalking/pull/7340#issuecomment-883220574
> > What do you mean own implementation? I don't think we would provide 2
kinds of implementations.
> > Could you provide more context?
>
> Makes it easy for users to add their own alarm implementations, It's mean
that user can use `selector` to extend sw alarm logical, like :
>
> ```yaml
> alarm:
> selector: ${SW_ALARM:myAlarm}
> default:
> myAlarm:
> ```
>
> For our case, we may use `myAlarm` to implement multi-tenant alarm
logical, and we can reuse `alarm-default-plugin` core at the same time.
I was objecting to this PR, the reason for doing this seems not very precise
and reasonable. You could do the same thing to extend the implementation,
without changing the structure.
All existing modules with this structure means SkyWalking is going to
provide multiple implementation, but we wouldn't. What you are doing in the
private fork is working as always. But why it has to be inside SkyWalking code
structure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
