hanahmily commented on a change in pull request #24:
URL: https://github.com/apache/skywalking-banyandb/pull/24#discussion_r676529414
##########
File path: pkg/pb/database.go
##########
@@ -25,141 +25,141 @@ import (
v1 "github.com/apache/skywalking-banyandb/api/proto/banyandb/v1"
)
-type shardEventBuilder struct {
+type ShardEventBuilder struct {
Review comment:
The exported func in this file return unexported types, which causes the
lint check to fail. @lujiajing1126 Would you pls check whether the way I fixed
is correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
