This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new ef68b3f  Fix issue that the time to remove the 
REQUEST_KEY_IN_RUNTIME_CONTEXT flag is incorrect (#2913)
ef68b3f is described below

commit ef68b3f2185f223a606ec0d38785f7848da03fd3
Author: Xin,Zhang <[email protected]>
AuthorDate: Thu Jun 20 08:51:54 2019 +0800

    Fix issue that the time to remove the REQUEST_KEY_IN_RUNTIME_CONTEXT flag 
is incorrect (#2913)
---
 .../spring/mvc/commons/interceptor/AbstractMethodInterceptor.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java
 
b/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java
index 1a98e7b..ab7c15a 100644
--- 
a/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java
+++ 
b/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java
@@ -154,10 +154,10 @@ public abstract class AbstractMethodInterceptor 
implements InstanceMethodsAround
                 if (response.getStatus() >= 400) {
                     span.errorOccurred();
                     Tags.STATUS_CODE.set(span, 
Integer.toString(response.getStatus()));
-
-                    
ContextManager.getRuntimeContext().remove(REQUEST_KEY_IN_RUNTIME_CONTEXT);
-                    
ContextManager.getRuntimeContext().remove(RESPONSE_KEY_IN_RUNTIME_CONTEXT);
                 }
+
+                
ContextManager.getRuntimeContext().remove(REQUEST_KEY_IN_RUNTIME_CONTEXT);
+                
ContextManager.getRuntimeContext().remove(RESPONSE_KEY_IN_RUNTIME_CONTEXT);
             }
 
             ContextManager.stopSpan();

Reply via email to