This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 85669fb  Fix `GRPCLogClientAppender` no context warning. (#7385)
85669fb is described below

commit 85669fb40f53e4a923dceb911428746cc0b0e7e8
Author: wuwen <[email protected]>
AuthorDate: Thu Jul 29 16:52:52 2021 +0800

    Fix `GRPCLogClientAppender` no context warning. (#7385)
---
 CHANGES.md                                                       | 1 +
 .../apm/toolkit/log/logback/v1/x/log/GRPCLogClientAppender.java  | 9 +++++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/CHANGES.md b/CHANGES.md
index ee30a04..3985ba1 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -40,6 +40,7 @@ Release Notes.
 * Update agent plugin for ElasticJob GA version
 * Remove the logic of generating instance name in 
`KafkaServiceManagementServiceClient` class.
 * Improve `okhttp` plugin performance by optimizing Class.getDeclaredField().
+* Fix `GRPCLogClientAppender` no context warning.
 
 #### OAP-Backend
 
diff --git 
a/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/log/GRPCLogClientAppender.java
 
b/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/log/GRPCLogClientAppender.java
index 9b5ffdd..b5856e1 100644
--- 
a/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/log/GRPCLogClientAppender.java
+++ 
b/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/log/GRPCLogClientAppender.java
@@ -19,17 +19,22 @@
 package org.apache.skywalking.apm.toolkit.log.logback.v1.x.log;
 
 import ch.qos.logback.core.OutputStreamAppender;
-import java.io.IOException;
 import java.io.OutputStream;
 
 public class GRPCLogClientAppender<E> extends OutputStreamAppender<E> {
+    
     public GRPCLogClientAppender() {
+    }
+
+    @Override
+    public void start() {
         setOutputStream(new OutputStream() {
             @Override
-            public void write(final int b) throws IOException {
+            public void write(final int b) {
                 // discarded
             }
         });
+        super.start();
     }
 
     @Override

Reply via email to