zooltd edited a comment on pull request #51: URL: https://github.com/apache/skywalking-eyes/pull/51#issuecomment-891544934
> This looks much better, just some nits. Can you please run this tool on [http://github.com/apache/skywalking-client-js](https://github.com/apache/skywalking-client-js) and [http://github.com/apache/skywalking-nodejs](https://github.com/apache/skywalking-nodejs) to see the results and paste here? #### For skywalking-client-js, the total output is shown as below: root@Samaritan:~/skywalking-eyes# ./bin/linux/license-eye -c ~/testPlace/skywalking-client-js/.licenserc.yaml d r INFO GITHUB_TOKEN is not set, license-eye won't comment on the pull request INFO Loading configuration from file: /root/testPlace/skywalking-client-js/.licenserc.yaml INFO Try to install nodejs packages in 5 seconds, press [s/S] and ENTER to skip INFO Time out, try to install packages INFO Run command: /usr/local/bin/npm install, please wait npm WARN old lockfile npm WARN old lockfile The package-lock.json file was created with an old version of npm, npm WARN old lockfile so supplemental metadata must be fetched from the registry. npm WARN old lockfile npm WARN old lockfile This is a one-time fix-up, please be patient... npm WARN old lockfile npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. npm WARN deprecated [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead. npm WARN deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies. added 652 packages, and audited 653 packages in 29s 50 packages are looking for funding run `npm fund` for details 5 vulnerabilities (4 moderate, 1 high) To address issues that do not require attention, run: npm audit fix To address all issues (including breaking changes), run: npm audit fix --force Run `npm audit` for details. Dependency | License --------- | ------------ js-base64 | BSD-3-Clause #### And for skywalking-nodejs: (`npm run generate-source` failed somehow) root@Samaritan:~/skywalking-eyes# ./bin/linux/license-eye -c ~/testPlace/skywalking-nodejs/.licenserc.yaml d r INFO GITHUB_TOKEN is not set, license-eye won't comment on the pull request INFO Loading configuration from file: /root/testPlace/skywalking-nodejs/.licenserc.yaml INFO Try to install nodejs packages in 5 seconds, press [s/S] and ENTER to skip INFO Time out, try to install packages INFO Run command: /usr/local/bin/npm install, please wait > [email protected] prepare > npm run generate-source > [email protected] generate-source > scripts/protoc.sh Could not make proto path relative: **/*.proto: No such file or directory /root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/protoc.js:41 throw error; ^ Error: Command failed: /root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/protoc --plugin=protoc-gen-grpc=/root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/grpc_node_plugin --js_out=import_style=commonjs,binary:/root/testPlace/skywalking-nodejs/src/proto/ --grpc_out=/root/testPlace/skywalking-nodejs/src/proto/ --plugin=protoc-gen-grpc=/root/testPlace/skywalking-nodejs/node_modules/.bin/grpc_tools_node_protoc_plugin **/*.proto Could not make proto path relative: **/*.proto: No such file or directory at ChildProcess.exithandler (child_process.js:390:12) at ChildProcess.emit (events.js:400:28) at maybeClose (internal/child_process.js:1055:16) at Socket.<anonymous> (internal/child_process.js:441:11) at Socket.emit (events.js:400:28) at Pipe.<anonymous> (net.js:675:12) { killed: false, code: 1, signal: null, cmd: '/root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/protoc --plugin=protoc-gen-grpc=/root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/grpc_node_plugin --js_out=import_style=commonjs,binary:/root/testPlace/skywalking-nodejs/src/proto/ --grpc_out=/root/testPlace/skywalking-nodejs/src/proto/ --plugin=protoc-gen-grpc=/root/testPlace/skywalking-nodejs/node_modules/.bin/grpc_tools_node_protoc_plugin **/*.proto' } Could not make proto path relative: **/*.proto: No such file or directory /root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/protoc.js:41 throw error; ^ Error: Command failed: /root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/protoc --plugin=protoc-gen-grpc=/root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/grpc_node_plugin --plugin=protoc-gen-ts=/root/testPlace/skywalking-nodejs/node_modules/.bin/protoc-gen-ts --ts_out=/root/testPlace/skywalking-nodejs/src/proto/ **/*.proto Could not make proto path relative: **/*.proto: No such file or directory at ChildProcess.exithandler (child_process.js:390:12) at ChildProcess.emit (events.js:400:28) at maybeClose (internal/child_process.js:1055:16) at Socket.<anonymous> (internal/child_process.js:441:11) at Socket.emit (events.js:400:28) at Pipe.<anonymous> (net.js:675:12) { killed: false, code: 1, signal: null, cmd: '/root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/protoc --plugin=protoc-gen-grpc=/root/testPlace/skywalking-nodejs/node_modules/grpc-tools/bin/grpc_node_plugin --plugin=protoc-gen-ts=/root/testPlace/skywalking-nodejs/node_modules/.bin/protoc-gen-ts --ts_out=/root/testPlace/skywalking-nodejs/src/proto/ **/*.proto' } npm ERR! code 1 npm ERR! path /root/testPlace/skywalking-nodejs npm ERR! command failed npm ERR! command sh -c npm run generate-source npm ERR! A complete log of this run can be found in: npm ERR! /root/.npm/_logs/2021-08-03T05_38_55_303Z-debug.log ERROR exit status 1 Dependency | License ------------------------------------ | ----------------------------------- google-protobuf | BSD-3-Clause grpc | Apache-2.0 semver | ISC tslib | 0BSD uuid | MIT winston | MIT @types/bytebuffer | MIT lodash.camelcase | MIT lodash.clone | MIT nan | MIT node-pre-gyp | BSD-3-Clause protobufjs | Apache-2.0 lru-cache | ISC @dabh/diagnostics | MIT async | MIT is-stream | MIT logform | MIT one-time | MIT winston/node_modules/readable-stream | MIT stack-trace | MIT triple-beam | MIT winston-transport | MIT @types/long | MIT @types/node | MIT detect-libc | Apache-2.0 mkdirp | MIT needle | MIT nopt | ISC npm-packlist | ISC npmlog | ISC rc | (BSD-2-Clause OR MIT OR Apache-2.0) rimraf | ISC node-pre-gyp/node_modules/semver | ISC tar | ISC ascli | Apache-2.0 bytebuffer | Apache-2.0 glob | ISC yargs | MIT lru-cache/node_modules/yallist | ISC colorspace | MIT enabled | MIT kuler | MIT colors | MIT fast-safe-stringify | MIT fecha | MIT ms | MIT fn.name | MIT inherits | ISC string_decoder | MIT util-deprecate | MIT readable-stream | MIT minimist | MIT debug | MIT iconv-lite | MIT sax | ISC abbrev | ISC osenv | ISC ignore-walk | ISC npm-bundled | ISC npm-normalize-package-bin | ISC are-we-there-yet | ISC console-control-strings | ISC gauge | ISC set-blocking | ISC deep-extend | MIT ini | ISC strip-json-comments | MIT chownr | ISC fs-minipass | ISC minipass | ISC minizlib | MIT safe-buffer | MIT yallist | ISC colour | MIT optjs | MIT long | Apache-2.0 fs.realpath | ISC inflight | ISC minimatch | ISC once | ISC path-is-absolute | MIT camelcase | MIT cliui | ISC decamelize | MIT os-locale | MIT string-width | MIT window-size | MIT y18n | ISC color | MIT text-hex | MIT core-util-is | MIT isarray | MIT process-nextick-args | MIT safer-buffer | MIT os-homedir | MIT os-tmpdir | MIT delegates | MIT aproba | ISC has-unicode | ISC object-assign | MIT signal-exit | ISC strip-ansi | MIT wide-align | ISC wrappy | ISC brace-expansion | MIT wrap-ansi | MIT lcid | MIT code-point-at | MIT is-fullwidth-code-point | MIT color-convert | MIT color-string | MIT ansi-regex | MIT balanced-match | MIT concat-map | MIT invert-kv | MIT number-is-nan | MIT color-name | MIT simple-swizzle | MIT is-arrayish | MIT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
