kezhenxu94 commented on a change in pull request #7399:
URL: https://github.com/apache/skywalking/pull/7399#discussion_r683444931
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -236,14 +236,17 @@
last_server_state_sync_time_in_seconds.tagEqual('production', 'catalog').downsam
## Metric level function
-There are three levels in metric: service, instance and endpoint. They extract
level relevant labels from metric labels, then informs the meter-system the
level to which this metric belongs.
+They extract level relevant labels from metric labels, then informs the
meter-system the level to which this metric belongs.
- `servcie([svc_label1, svc_label2...])` extracts service level labels from
the array argument.
- `instance([svc_label1, svc_label2...], [ins_label1, ins_label2...])`
extracts service level labels from the first array argument,
extracts instance level labels from the second array argument.
- `endpoint([svc_label1, svc_label2...], [ep_label1, ep_label2...])` extracts
service level labels from the first array argument,
extracts
endpoint level labels from the second array argument.
-
+ - `serviceRelation(DetectPoint, [svc_label1...], [related_svc_label1...])`
DetectPoint including `DetectPoint.CLIENT` and `DetectPoint.SERVER`,
+ extracts `service` labels from the first array argument, extracts `related
service` labels from the second array argument.
+ If `DetectPoint.CLIENT` the `related service` is upstream of the `service`.
+ If `DetectPoint.SERVER` the `related service` is downstream of the
`service`.
Review comment:
Should we make the position of `source` and `target` services fixed,
i.e. the first array argument being `source service` and the second array
argument being `target service`? Because this is a service relation metrics,
and the `DetectPoint` should not affect the `source` and `target` services.
Also, consider if the `DetectPoint` is a variable (not known constant value),
how to determine the position of the 2 labels array arguments?
##########
File path:
oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/topology-service-relation.yml
##########
@@ -120,127 +120,207 @@ templates:
}
]
},
- "tcp":{
+ "tcp":{
Review comment:
these are unnecessary changes and impossible to review, just because of
a space
##########
File path: test/e2e/e2e-test/src/test/resources/expected/metricsservice/topo.yml
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+nodes:
+ - id: not null
+ name: e2e::reviews
+ type: null
+ isReal: true
+ - id: not null
+ name: e2e::productpage
+ isReal: true
+ - id: not null
+ name: e2e::details
+ type: null
+ isReal: true
Review comment:
Why is there no `ratings` service?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
