sonatype-lift[bot] commented on a change in pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#discussion_r683693254
##########
File path: skywalking/trace/span.py
##########
@@ -57,7 +57,7 @@ def __init__(
self.layer = layer or Layer.Unknown # type: Layer
self.inherit = Component.Unknown # type: Component
- self.tags = [] # type: List[Tag]
+ self.tags = defaultdict(list) # type: DefaultDict[str, Union[Tag,
List[Tag]]]
Review comment:
*Incompatible attribute type:* Attribute `tags` declared in class
`Span` has type `DefaultDict[str, Union[List[Tag], Tag]]` but is used as type
`DefaultDict[Variable[collections._KT], List[Variable[_T]]]`.
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
