wu-sheng commented on a change in pull request #7417:
URL: https://github.com/apache/skywalking/pull/7417#discussion_r684188097



##########
File path: oap-server/server-bootstrap/pom.xml
##########
@@ -280,6 +280,7 @@
                         <exclude>fetcher-prom-rules/</exclude>
                         <exclude>envoy-metrics-rules/</exclude>
                         <exclude>meter-analyzer-config/</exclude>
+                        <exclude>openapi-definitions/</exclude>

Review comment:
       I think `exclude` is not enough.
   
   > org.apache.skywalking.oap.server.library.module.ModuleStartException: path 
not found: openapi-definitions
   
   This error makes the booting fails. You should modify these two to create an 
empty folder at least.
   
   
https://github.com/apache/skywalking/blob/4e7d80fb88a603e076f6c53ed9817d81dc55da3d/apm-dist/src/main/assembly/binary.xml#L53-L69
   
https://github.com/apache/skywalking/blob/4e7d80fb88a603e076f6c53ed9817d81dc55da3d/apm-dist-es7/src/main/assembly/binary-es7.xml#L53-L69
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to