wu-sheng commented on a change in pull request #2935: Add end to end tests URL: https://github.com/apache/skywalking/pull/2935#discussion_r296469119
########## File path: apm-test/e2e/e2e-samples/src/main/docker/Dockerfile ########## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM openjdk:8-jre-alpine + +LABEL maintainer="[email protected]" + +ARG DIST_JAR + +EXPOSE 8080 + +ENV HOME=/home +ENV DIST_JAR=$DIST_JAR +ENV COMMIT_HASH=latest + +VOLUME $HOME + +COPY target/$DIST_JAR $HOME Review comment: Same happens here. Mount the volume rather than repackage images. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
