kezhenxu94 commented on issue #6018: URL: https://github.com/apache/skywalking/issues/6018#issuecomment-896416735
> > Now some of the http client plugins record the `username:password` into the tag `peer` and `url`, this should be removed explicitly. > > Example request url might be http://username:[email protected] > > Should I remove the auth part entirely from url/peer or replace any `userabc:pwcde` with literal `username:password`? I feel like replacing may be a good choice too (I hope no one uses `password` as their actual password). @kezhenxu94 @wu-sheng @Superskyyy I don't see any point to replace them with placeholders, if we don't want to record them why bother to bring extra bytes to store and network load? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
