wu-sheng commented on a change in pull request #58:
URL:
https://github.com/apache/skywalking-satellite/pull/58#discussion_r686494729
##########
File path: test/e2e/base/base-compose.yml
##########
@@ -51,8 +80,13 @@ services:
- e2e
environment:
SW_AGENT_COLLECTOR_BACKEND_SERVICES: satellite:11800
+ SW_GRPC_LOG_SERVER_HOST: satellite
+ SW_GRPC_LOG_SERVER_PORT: 11800
+ SW_COLLECTOR_GET_PROFILE_TASK_INTERVAL: 1
SW_AGENT_NAME: e2e-service-provider
- JAVA_OPTS:
-javaagent:/skywalking/agent/skywalking-agent.jar=logging.output=CONSOLE,agent.instance_name=provider1
+ JAVA_OPTS: >-
+
-javaagent:/skywalking/agent/skywalking-agent.jar=logging.output=CONSOLE,agent.instance_name=provider1
+ -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005
Review comment:
> > Those configurations valuable for testing could be added. We didn't
have this infra tool before, now, the status changes.
>
>
>
> Not only for testing, it also applies in production deployment with our
official Docker image. If we provide a configuration item for Java agent but
it's impossible to configure it via env var, our Docker image makes less sense
as users have to rebuild or hack the official Docker image.
>
>
>
> > My argue was only, we need to set the boundaries clear, which we accept,
or reject.
>
>
>
> IMHO, if we say a behavior of agent is configurable, is should be
configurable via env var in containerized scenarios.
>
>
If you want this, we need all configurations like the OAP YMAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
