wu-sheng commented on a change in pull request #2934: Use ids query method
instead of get method for metrics persistence.
URL: https://github.com/apache/skywalking/pull/2934#discussion_r296470189
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/MetricsEsDAO.java
##########
@@ -42,9 +42,9 @@
@Override public Metrics get(Model model, Metrics metrics) throws
IOException {
String modelName = TimeSeriesUtils.timeSeries(model,
metrics.getTimeBucket());
Review comment:
This looks like still reading from the physical index, I think we should
read from alias name, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
