lujiajing1126 commented on pull request #7444: URL: https://github.com/apache/skywalking/pull/7444#issuecomment-897287517
> > > > @wu-sheng Pls kindly update the integration branch. Thx > > > > > > > > > Why should we have this branch in this repo and sync it over and over? instead of creating it on @lujiajing1126 your fork repo? > > > > > > The integration will not be merged to the master branch and will be pending util all features are ready (Trace, Log and Metrics). > > The codes can be in your fork repo always and you can sync from upstream at anytime you like, and do whatever you like until you think it's ready to open a pull request. Yes. What I was doing is fetching from upstream (i.e. Apache/Skywalking repo) and rebase from the `banyandb-integration` branch. So when I submit the PR, the compare view will be clear that it only shows what I have changed. Or it will be contaminated with codes from master. But I guess it would also be OK if you sync when I submit the next PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
