wu-sheng commented on a change in pull request #7271:
URL: https://github.com/apache/skywalking/pull/7271#discussion_r688908258
##########
File path:
oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/MultiScopesAnalysisListener.java
##########
@@ -240,12 +240,15 @@ private void setPublicAttrs(SourceBuilder sourceBuilder,
SpanObject span) {
sourceBuilder.setLatency((int) latency);
sourceBuilder.setResponseCode(Const.NONE);
span.getTagsList().forEach(tag -> {
- if (SpanTags.STATUS_CODE.equals(tag.getKey())) {
+ if (SpanTags.HTTP_RESPONSE_STATUS_CODE.equals(tag.getKey())) {
Review comment:
You could add a change log at the project section to highlight this
change, and the new agent plugins' response code would not be compatible with
old OAP versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
