wu-sheng commented on a change in pull request #7509:
URL: https://github.com/apache/skywalking/pull/7509#discussion_r692958423
##########
File path:
oap-server/server-configuration/configuration-zookeeper/src/main/java/org/apache/skywalking/oap/server/configuration/zookeeper/ZookeeperConfigWatcherRegister.java
##########
@@ -46,9 +51,28 @@ public
ZookeeperConfigWatcherRegister(ZookeeperServerSettings settings) throws E
@Override
public Optional<ConfigTable> readConfig(Set<String> keys) {
ConfigTable table = new ConfigTable();
- keys.forEach(s -> {
- ChildData data = this.childrenCache.getCurrentData(this.prefix +
s);
- table.add(new ConfigTable.ConfigItem(s, data == null ? null : new
String(data.getData())));
+ keys.forEach(key -> {
+ if (this.getRegister().get(key).getWatcher().getWatchType() ==
ConfigChangeWatcher.WatchType.GROUP) {
Review comment:
Make `this.getRegister().get(key).getWatcher().getWatchType()` a parent
method please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
