Superskyyy commented on pull request #156: URL: https://github.com/apache/skywalking-python/pull/156#issuecomment-904301552
> Hi @Superskyyy , I just test (on MacOS) and review the codes, and left some comments. > > Since you did a lot of test cases, it would be perfect if you can add those cases into our test matrix in GitHub Actions, if you find any trouble in adding that, ping me at anytime, I can offer my help! I'm actually thinking what if I change/ duplicate our existing plugin unit tests to use the `sw-python` command in docker-compose command, instead of calling agent in those `consumer` `provider`s, that should work. Idk if we need to keep the old tests that directly call `agent.start()`, just that having two versions doing essentially the same thing will double the GHA running time, which seems awfully long. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
