kezhenxu94 commented on pull request #138: URL: https://github.com/apache/skywalking-python/pull/138#issuecomment-905481630
Hi @tom-pytel > Set __finished.wait(0) in the report thread instead of blocking for 3 or 30 seconds because this could be detrimental in high throughput scenarios. Now the only report thread blocking that happens in is the report generators of the various protocols waiting on the queue. Setting `__finished.wait(0)` makes it infinitely retry to connect without any delay when the OAP is down, this may keep the CPU unnecessarily busy, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
